Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Low-ProFiles
reviewed
Oct 9, 2024
Comment on lines
+30
to
+31
| grid-template-areas: 'logo ㆍ ㆍ ㆍ ㆍ ㆍ ㆍ ㆍ ㆍ button'; | ||
| grid-template-columns: repeat(10, 1fr); |
| <Link to={'/category'}> | ||
| <SideMenu> | ||
| <MdMovie /> | ||
| 영화 |
There was a problem hiding this comment.
SideMenu 스타일에서 justify-content: space-around;를 추가하고 width 값을 조정하면   없이 스타일을 조정할 수 있어요!
Comment on lines
3
to
6
| import cbr from '../assets/cbr500r.png'; | ||
| import ninja from '../assets/ninja.png'; | ||
| import rocket from '../assets/rocket.png'; | ||
| import r1 from '../assets/r1.png'; |
There was a problem hiding this comment.
저는 개인적으로 이렇게 import 문이 길어질 때 정리하고 싶더라구요.. 혹시 민서님도 그렇다면 assets 폴더에 아래처럼 index.js를 추가하고
// index.js
export { default as cbr } from "./cbr500r.png";
export { default as ninja } from "./ninja.png";
export { default as r1 } from "./r1.png";
export { default as rocket } from "./rocket.png";
export { default as watcha } from "./watcha.png";
category.jsx에서는 import { cbr, ninja, r1, rocket } from "../assets"; 이렇게 깔끔하게 한 줄로 정리가 가능하답니다!
Comment on lines
8
to
9
| let { id } = useParams(); | ||
| id = id || 'popular'; |
There was a problem hiding this comment.
여기서 id가 falsy한 값을 띄면 'popular'가 할당이 될 거여서 const으로 하는 것이 좋습니다! 혹시 이름이 겹쳐서 고민이시라면 아래처럼도 가능해요!
Suggested change
| let { id } = useParams(); | |
| id = id || 'popular'; | |
| const { id: paramId } = useParams(); | |
| const id = paramId || "popular"; |
There was a problem hiding this comment.
- let은 지양하시는게 좋지만 사용하게 된다면 특정 함수 내부에서 쓰는 등 specific한 scope에서만 사용하시는 것을 권장드립니다! let에 새로운 값이 할당되는 것을 리액트가 알 수가 없어서 일관된 라이프 사이클 밖에서 움직일 수 있게 되거든요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge pull request는 모든 리뷰가 완료된 후에 눌러주세요!
1. Add a title
2. Reviewers
3. Assignees
4. Labels