Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow null elements in support array #203

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

Pl217
Copy link
Contributor

@Pl217 Pl217 commented Dec 30, 2024

Note

To be merged after admin command from https://github.com/UN-OCHA/hpc_service/pull/3685 is run

After fixing all the records which had null in support array, we can simplify the codec.

@Pl217 Pl217 added the ready for review All comments have been addressed, and the Pull Request is ready for review label Dec 30, 2024
@Pl217 Pl217 requested a review from a team as a code owner December 30, 2024 20:27
@enxtur enxtur assigned Pl217 and unassigned enxtur Jan 13, 2025
@enxtur enxtur added ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished. and removed ready for review All comments have been addressed, and the Pull Request is ready for review labels Jan 13, 2025
Base automatically changed from HPC-9997 to develop January 16, 2025 15:44
After fixing all the records which had `null`
in `support` array, we can simplify the codec
@enxtur enxtur force-pushed the remove-null-support branch from c63465d to 7d8057c Compare January 22, 2025 15:22
@enxtur enxtur merged commit 5206bd1 into develop Jan 22, 2025
2 checks passed
@enxtur enxtur deleted the remove-null-support branch January 22, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants