Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPC-8569 HPC-8597 HPC-8539 Flows table #313

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

czmj
Copy link
Contributor

@czmj czmj commented Jun 21, 2022

Covers listing, pagination, sorting and query strings for the flows table used on the "flows" and "pending flows" pages.
Relies on #305 which must be merged first.

Also some fixes in https://github.com/UN-OCHA/hpc_service/pull/2720 will be needed for sorting to work fully as there were some duplicate joins in the squel queries meaning I was getting "property is defined more than once" errors from the backend.

@czmj czmj requested a review from a team as a code owner June 21, 2022 20:20
@czmj czmj added the pending prior merge Another Pull Request needs to be merged before this one label Jun 21, 2022
@czmj czmj force-pushed the feature/HPC-8569-list-flows branch from 3267beb to fce00b7 Compare June 23, 2022 06:35
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@czmj czmj force-pushed the feature/HPC-8569-list-flows branch from fce00b7 to 85d8efc Compare June 23, 2022 06:38
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@czmj czmj force-pushed the feature/HPC-8569-list-flows branch from 85d8efc to c75cf8b Compare June 23, 2022 06:46
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@czmj czmj force-pushed the feature/HPC-8569-list-flows branch from c75cf8b to b625fad Compare June 27, 2022 15:32
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@czmj czmj force-pushed the feature/HPC-8569-list-flows branch from b625fad to 9f91173 Compare June 27, 2022 15:37
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@czmj czmj force-pushed the feature/HPC-8569-list-flows branch from 9f91173 to 20bfaba Compare June 29, 2022 09:23
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@czmj czmj force-pushed the feature/HPC-8569-list-flows branch from 20bfaba to ad4224b Compare June 29, 2022 12:31
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@czmj czmj force-pushed the feature/HPC-8569-list-flows branch from ad4224b to 2f9fb13 Compare July 4, 2022 08:07
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@czmj czmj force-pushed the feature/HPC-8569-list-flows branch from 2f9fb13 to cced7c5 Compare July 4, 2022 11:20
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@czmj czmj force-pushed the feature/HPC-8569-list-flows branch from cced7c5 to d1f48f1 Compare July 14, 2022 11:28
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@czmj czmj force-pushed the feature/HPC-8569-list-flows branch from d1f48f1 to 35b33e5 Compare July 23, 2022 16:10
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@czmj czmj force-pushed the feature/HPC-8569-list-flows branch from 35b33e5 to 5b6a2fc Compare July 26, 2022 16:31
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@czmj czmj force-pushed the feature/HPC-8569-list-flows branch from 5b6a2fc to 3ff592e Compare July 27, 2022 01:57
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@czmj czmj force-pushed the feature/HPC-8569-list-flows branch from 3ff592e to 02256ba Compare July 28, 2022 11:22
@czmj czmj added ready for review All comments have been addressed, and the Pull Request is ready for review and removed pending prior merge Another Pull Request needs to be merged before this one labels Jul 28, 2022
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@czmj czmj changed the title HPC-8569 HPC-8597 HPC-8539 HPC-8569 HPC-8597 HPC-8539 Flows table Jul 28, 2022
@czmj czmj force-pushed the feature/HPC-8569-list-flows branch 2 times, most recently from 280e997 to 4663d52 Compare August 2, 2022 07:27
@czmj czmj force-pushed the feature/HPC-8569-list-flows branch from 4663d52 to de5a631 Compare August 11, 2022 11:08
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@czmj czmj force-pushed the feature/HPC-8569-list-flows branch from de5a631 to 48b6303 Compare August 11, 2022 16:15
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@czmj czmj unassigned Pl217 Aug 24, 2022
@czmj czmj removed the ready for review All comments have been addressed, and the Pull Request is ready for review label Aug 24, 2022
@czmj czmj added the ready for review All comments have been addressed, and the Pull Request is ready for review label Sep 5, 2022
@czmj czmj force-pushed the feature/HPC-8569-list-flows branch from 48b6303 to 88c918b Compare September 5, 2022 15:59
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@Pl217 Pl217 force-pushed the feature/HPC-8569-list-flows branch from 88c918b to 3b025aa Compare July 7, 2023 12:58
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

"amountUSD": "Montant USD",
"sourceOrganization": "Organisation source",
"destinationOrganization": "Organisation de destination",
"destinationPlan": "Destination Plan",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plan de Destination

@Pl217 Pl217 assigned Onitoxan and unassigned Pl217 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review All comments have been addressed, and the Pull Request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants