specified logging if an admin set name couldnt be found

UNC-Libraries · Aug 30, 2024 · bd1921e · bd1921e
1 parent c9a93fc
commit bd1921e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/app/helpers/work_utils_helper.rb b/app/helpers/work_utils_helper.rb
@@ -7,8 +7,9 @@ def self.fetch_work_data_by_fileset_id(fileset_id)
     admin_set_name = work['admin_set_tesim']&.first
     # If the admin set name is not nil, fetch the admin set
     # Set the admin set to an empty hash if the solr query returns nil
-    admin_set = admin_set_name ? ActiveFedora::SolrService.get("title_tesim:#{admin_set_name}", { rows: 1, 'df' => 'title_tesim'})['response']['docs'].first || {} : {}
-    Rails.logger.warn("No admin set found for title_tesim: #{admin_set_name}") if admin_set.blank?
+    admin_set = admin_set_name ? ActiveFedora::SolrService.get("title_tesim:#{admin_set_name}", { :rows => 1, 'df' => 'title_tesim'})['response']['docs'].first || {} : {}
+    warning_message = admin_set_name ? "No admin set found for title_tesim: #{admin_set_name}" : "No admin set found with fileset id: #{fileset_id}"
+    Rails.logger.warn(warning_message) if admin_set.blank?
 
     {
       work_id: work['id'] || 'Unknown',

diff --git a/spec/services/tasks/download_stats_migration_service_spec.rb b/spec/services/tasks/download_stats_migration_service_spec.rb
@@ -8,7 +8,7 @@
   let(:service) { described_class.new }
 
   before do
-    allow(ActiveFedora::SolrService).to receive(:get).with("title_tesim:#{admin_set_title}", { rows: 1, 'df' => 'title_tesim'}).and_return('response' => { 'docs' => [mock_admin_set] })
+    allow(ActiveFedora::SolrService).to receive(:get).with("title_tesim:#{admin_set_title}", { :rows => 1, 'df' => 'title_tesim'}).and_return('response' => { 'docs' => [mock_admin_set] })
   end
 
   after do