HYC-1818 - Fix share with user error #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbpennel
force-pushed
the
hyc-1818-share
branch
from
95f7cf9 to
6ef179c
Compare
bbpennel
changed the title
…, then switch it to being the uid since we are storing agents with just the uid rather than the email address
…pdate method to using an alias_method. Update honors thesis test to check outcomes rather than method calls
bbpennel
changed the title
sharonluong
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://unclibrary.atlassian.net/browse/HYC-1818
http://projecthydra.org/ns/auth/person#[email protected]rather thanhttp://projecthydra.org/ns/auth/person#user. This is the default behavior in fedora, but not what we are doing everywhere else in the code base, so permissions granted this way were having no affect. So this PR converts email usernames into UIDs when updating the permissions on a work, which resolves the issue