Mp 2440 version overview #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lder, removed unused css classes
chopachop
changed the base branch from
master
to
feature/MP-2381-versioning-dashboard
chopachop
requested review from
naueramant,
arcuo,
xEyad,
rimonnassory,
samirhabibi,
ahmedzaki20,
dimitur2204,
dietzy1 and
JosipBr
rimonnassory
reviewed
Jul 9, 2024
rimonnassory
reviewed
Jul 9, 2024
rimonnassory
reviewed
Jul 9, 2024
rimonnassory
reviewed
Jul 9, 2024
rimonnassory
reviewed
Jul 9, 2024
rimonnassory
reviewed
Jul 9, 2024
| borderRadius: "sm", | ||
| flexShrink: 1, | ||
| overflow: "auto", | ||
| minHeight: 0, |
There was a problem hiding this comment.
then we need to make css files for every component to be aligned. Not sure if it worth it for that small internal project. What would you recommend @naueramant ?
There was a problem hiding this comment.
even if it is an internal project we should follow the guidlines for project structure.
…ed App.tsx and App.css
chopachop
merged commit 4af12c1
into
feature/MP-2381-versioning-dashboard
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Add versions overview that displays all translation versions for the specific project
What has changed?
Jira links