Support new lifter unsupported opcode format #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailrst
force-pushed
the
support-lifter-error-structure
branch
from
14c1641 to
5855138
Compare
ailrst
changed the title
l-kent
reviewed
Dec 23, 2024
| } | ||
| Logger.error(s"""Semantics parse error:\n line: $line\n$extra""") | ||
| throw e | ||
| } | ||
| } | ||
|
|
||
| val parserMap = semantics.map(_.map((k: String, v: Array[Array[String]]) => (k, v.map(_.map(parse_insn))))) | ||
| val parserMap : Map[String, List[Either[(String,String), List[StmtContext]]]] = |
There was a problem hiding this comment.
(String, String) should probably be a case class instead of a tuple to make the semantics of it clearer
|
Would it be cleaner if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates frontend to support the format in UQ-PAC/gtirb-semantics#22
Test code: gate_server_example.tar.gz
Also adds a case to loading
cvt_bool_bvthat wasn't covered previously.