ci: use nix #50
Merged
ci: use nix #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrinafyi
force-pushed
the
use-nix
branch
2 times, most recently
from
66c3cc4 to
5a9ce68
Compare
Update test.yml Update test.yml Update test.yml Update test.yml Update test.yml Update test.yml Update test.yml Update test.yml Update test.yml boopfdsa no opam asd add bash arguments. update workflow
touch touch remove pr trigger run on github changes Update opam.yml Update opam.yml opam exec dune
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Dockerfile is unmaintained and has fallen out of date. It also never saw use as a common development environment so it's not a good base for the CI.
This changes the aslp CI to use the now-preferred Nix environment. This has the added benefit of offering more transparency than a Docker container's binary blob.
To make sure we can still build with plain opam, it might be useful to run a weekly build with only opam/dune. This will be slow, but it would just be a sanity check.
For reference, the previous Dockerfile was here: https://github.com/katrinafyi/pac-environment