Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lighthouse accessibility score #695

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

slesaad
Copy link
Collaborator

@slesaad slesaad commented Jan 13, 2025

This improves the lighthouse accessibility score.

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for ghg-demo ready!

Name Link
🔨 Latest commit a92edae
🔍 Latest deploy log https://app.netlify.com/sites/ghg-demo/deploys/67856e5cf5624e00086c20e2
😎 Deploy Preview https://deploy-preview-695--ghg-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@slesaad slesaad changed the title Improve lighthouse score Improve lighthouse accessibility score Feb 4, 2025
@slesaad slesaad marked this pull request as ready for review February 4, 2025 16:11
@sanzog03
Copy link

sanzog03 commented Feb 4, 2025

image
This is missing 🤔 @ram-sharan25

@ram-sharan25
Copy link

This issue has been resolved.
Each CarouselItem is a Card item and is rendered as li. Additionally, it is nested within CardGroup which is rendered as a ul.
image

@ram-sharan25 ram-sharan25 merged commit 5eb476b into develop Feb 4, 2025
6 checks passed
@ram-sharan25 ram-sharan25 deleted the accessibility-lighthouse branch February 4, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants