-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
151 cran 310 release #152
Merged
Merged
151 cran 310 release #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and not required to use the package normally
Closed
cthunes
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes for CRAN release all look good! I ran R CMD check successfully with 0 errors, warnings, and notes.
brown-jason
added a commit
that referenced
this pull request
Oct 17, 2023
* updated docs * added github to buildignore * added documentation for invitrodb_dd data file * updated version number * fixes variable binding note * moved vdiffr from imports to suggests since it is only used in tests and not required to use the package normally * added default multi for old style plots * accepted and resolved minor snapshot test difference based on testing environment * updated news and cran-comments * added additional rhub to cran comments
brown-jason
added a commit
that referenced
this pull request
Nov 28, 2023
* updated docs * added github to buildignore * added documentation for invitrodb_dd data file * updated version number * fixes variable binding note * moved vdiffr from imports to suggests since it is only used in tests and not required to use the package normally * added default multi for old style plots * accepted and resolved minor snapshot test difference based on testing environment * updated news and cran-comments * added additional rhub to cran comments
brown-jason
added a commit
that referenced
this pull request
Nov 28, 2023
This reverts commit 8f8a646.
brown-jason
added a commit
that referenced
this pull request
Nov 28, 2023
This reverts commit 8f8a646.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see why these are required, pull down the main branch and run devtools::check()
Notice the notes/warnings/errors.
With this branch you should see 0 errors, warnings, or notes after running devtools::check()
Also there are things related to release such as short overviews for news and cran comments.