Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mc overwrite of hitc to bool in tcplSubsetChid to actc #302

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

cthunes
Copy link
Contributor

@cthunes cthunes commented Oct 15, 2024

image

This change preserves the continuous hitcall and calculates a new column called actc instead, which is used in the following two lines for chit calculation.

Was not necessary to add change for sc since hitc can only be binary anyway.

Closes #189.

@cthunes cthunes added the bug label Oct 15, 2024
@cthunes cthunes self-assigned this Oct 15, 2024
@cthunes cthunes linked an issue Oct 15, 2024 that may be closed by this pull request
Copy link
Collaborator

@madison-feshuk madison-feshuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Hitc column preserved

@cthunes cthunes merged commit ceacf6a into dev Oct 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tcplSubsetChid overwrites hitc to boolean
2 participants