Oil refineries ng processing #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creation of the ng_processing_proxy and oil_refineries_proxy
Added uniform distribution of emissions across state for states missing proxy data.
Changed Header to be consistent with other proxy headers. Removed imports that were unused (please verify with author that these were not used): - os - pyarrow.parquet - V3_DATA_PATH Added function docstring with Args Questions: - Are lines 388 and 394 redundant? It may not impact the script performance, but I wanted to check. - Lines 441, 442. Should line 441 be commented out as well if assert is commented out on line 442, as sums may not need to be calculated if it is not being asserted. Ignored lines >88 char due to object name lengths and process complexity. Added some documentation context, but overall code was commented well.
Changed Header to make consistent with other proxy scripts. Removed parquet import, unused in script. Added pytask function docstring. Minor edits to bring some lines <88 char. Added some documentation in larger chunks. Overall well documented.
|
@haclohman I committed updates for task_ng_processing_proxy and task_oi_refineries_proxy. Overall, scripts were well documented. I added notes to commit edits. Primary edits were to header and chunk documentation to make similar to other proxy scripts. Let me know if you approve the edits or want to follow up. Then we can ping Nick to review/merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ng_processing_proxy and oil_refineries_proxy