Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bug fixes and minor enhancements #138

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Various bug fixes and minor enhancements #138

merged 7 commits into from
Oct 12, 2023

Conversation

cbuahin
Copy link
Collaborator

@cbuahin cbuahin commented Aug 17, 2023

This PR addresses the following issues:

#136 Fix hotstart file
#109 Fix large numbers in report file
#70 Will fix as a minor release update per Michael's recommendation.
#144 Fix elliptical pipe geometry

@cbuahin cbuahin temporarily deployed to testing August 17, 2023 13:57 — with GitHub Actions Inactive
@cbuahin
Copy link
Collaborator Author

cbuahin commented Aug 22, 2023

@michaeltryby , this is a WIP. I will invite you to review when complete.

@michaeltryby
Copy link
Collaborator

Sounds good @cbuahin. I will hold any further comment until your PR is ready for review

@cbuahin cbuahin temporarily deployed to testing October 5, 2023 12:52 — with GitHub Actions Inactive
@cbuahin cbuahin temporarily deployed to testing October 5, 2023 14:06 — with GitHub Actions Inactive
@cbuahin cbuahin temporarily deployed to testing October 5, 2023 14:19 — with GitHub Actions Inactive
@cbuahin cbuahin requested a review from michaeltryby October 5, 2023 14:31
@michaeltryby michaeltryby temporarily deployed to testing October 10, 2023 19:52 — with GitHub Actions Inactive
@michaeltryby michaeltryby temporarily deployed to testing October 10, 2023 20:21 — with GitHub Actions Inactive
Copy link
Collaborator

@michaeltryby michaeltryby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Excellent job @cbuahin!

@cbuahin
Copy link
Collaborator Author

cbuahin commented Oct 10, 2023

Hey @michaeltryby , thanks for taking time to review! I appreciate it.

@cbuahin cbuahin merged commit 04d85cc into develop Oct 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants