Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for 5.3.0 release #179

Draft
wants to merge 44 commits into
base: develop
Choose a base branch
from
Draft

PR for 5.3.0 release #179

wants to merge 44 commits into from

Conversation

cbuahin
Copy link
Collaborator

@cbuahin cbuahin commented Jun 3, 2024

No description provided.

cbuahin added 28 commits November 1, 2023 10:56
@cbuahin
Work in progress addressing #149
6bcd52c
@cbuahin
Addressing bug for mod. horton #59
81095bc
@cbuahin
Addressing bug for mod. horton #59
353f8fe
@cbuahin
Enabling draining in isolated and surcharged storages #149
ee1b5ef
@cbuahin
Restore openmp for node updating
f9fa0ed
@cbuahin
Valid double comparison since sumdqdh is initialized to zero for dang…
059d342 
…ling node #149
@cbuahin
Make sure ellipse ratio is 1.56 to be consistent with GUI #144
d93cb32
@cbuahin
Leave users to prescribe rise and span #144
a621234
@cbuahin
Address zero depth outfall bug #154
4606020
@cbuahin
Bumping minor version number up
a6fa0d5
@cbuahin
Addressing TotalDuration precision bug #152
57cf5fa
@cbuahin
Limiting cummulative infiltration to max #158
d67a757
@cbuahin
Added support for saving multiple hotstart files at specified times #150
a409713
@cbuahin
Modified code to use global consts instead of locally defined values #70
e3309b6
@cbuahin
WIP addressing #162, #150
9cad38b
@cbuahin
WIP addressing #162, #150
91de2fd
@cbuahin
WIP addressing #162, #150
cd5120d
@cbuahin
WIP addressing #162, #150
5d933ae
@cbuahin
WIP addressing #162, #150; Remove actions for bug_fixes branch
ea5e68a
@cbuahin
WIP addressing #162, #150
e1f906e
@cbuahin
Expand API to return error code and support unit testing #162
58e330b
@cbuahin
WIP on expanding unit tests #162, #150; other minor refactoring
66e9f61
@cbuahin
WIP on expanding unit tests #162, #150; other minor refactoring
1b4559e
@cbuahin
WIP on expanding unit tests #162, #150; other minor refactoring
71c79e3
@cbuahin
Work in progress #162, #163
89fd7dd
@cbuahin
Addressing crashing for long comments in timeseries #165
bbaf4fe
@cbuahin
Add runoff from closed rain barrel to return flow #166
9d3bb8d
@cbuahin
Add runoff from closed rain barrel to return flow #166
25dd291
@LRossman
Copy link
Collaborator

LRossman commented Jun 3, 2024

@cbuahin I'm happy to see you are making progress on pushing out a version 5.3. I was hoping it would include the improvements to how submerged inlets are handled as described in issue #139 and implemented in the the inlet_improvement branch. As I didn't see it included on this set of commits I'm hoping you will eventually add it to the v5.3 pipeline since it provides a more physically realistic way of modeling sewer overflow onto the street than does the current method used in v5.2.4.

@michaeltryby
Copy link
Collaborator

Great work @cbuahin!

@cbuahin
Copy link
Collaborator Author

cbuahin commented Jun 3, 2024 •
edited
Loading

@LRossman, thanks for the reminder. There are a couple more issues to address as part of this release. I will work on bringing in the solution you provided for #139 as part of that work.

@jubilee2
Copy link

jubilee2 commented Jun 8, 2024 •
edited
Loading

can you include this update for #168 (comment)

@cbuahin
Copy link
Collaborator Author

cbuahin commented Jun 13, 2024

@jubilee2 , yes, #168 is one of the issues we are addressing for v5.3.0. You can check the issues for the v5.3.0 milestone here

@jubilee2
Copy link

@jubilee2 , yes, #168 is one of the issues we are addressing for v5.3.0. You can check the issues for the v5.3.0 milestone here

Thank you

@MdoubleDash
Copy link

@cbuahin, appreciate your efforts. Do you have any plans for addressing lower priority enhancements/issues such as #171?

@cbuahin cbuahin added this to the v5.3.0 milestone Aug 15, 2024
@cbuahin cbuahin self-assigned this Oct 10, 2024
cbuahin added 13 commits November 20, 2024 15:22
@cbuahin
WIP; New cython bindings for expanded API; docs; unit tests #204, #162,
73b057a 
#163, #184, #180
@cbuahin
WIP; New cython bindings for expanded API for unit and reg tests; docs …
9efa97a 
…#204, #162, #163, #184, #180
@cbuahin
Finalize output API; New cython bindings for expanded API; docs; unit…
53f9909 
… tests #204, #162, #163, #184, #180
@cbuahin
WIP finalizing core api; consolidating readme; #204, #162, #163, #184, …
2a6acde 
…#180
@cbuahin
Fix setter error in solver.pyx; consolidating readme; #204, #162, #163,
2a6843e 
#184, #180
@cbuahin
WIP API bindings for pollutants #204, #162, #163, #184, #180
5b87a2b
@cbuahin
WIP API and bindings unit testing #204, #162, #163, #184, #180
6c08f7e
@cbuahin
WIP finalizing core api, unit testing, installation config; #204, #162…
11f2a60 
…, #163, #184, #180
@cbuahin
Installation config; #204, #162, #163, #184, #180
ef8f5b7
@cbuahin
WIP API and bindings unit testing; cleaning up #204, #162, #163, #184, …
8e3dca2 
…#180
@cbuahin
WIP API and bindings unit testing; cleaning up #204, #162, #163, #184, …
14e0a0a 
…#180
@cbuahin
WIP API and bindings unit testing; cleaning up #204, #162, #163, #184, …
0a78d5e 
…#180
@cbuahin
WIP API and bindings unit testing; cleaning up #204, #162, #163, #184, …
3369838 
…#180
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cbuahin cbuahin

Labels
None yet
Projects
None yet
Milestone
v5.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cbuahin @LRossman @michaeltryby @jubilee2 @MdoubleDash