Improve check valve validation and setting #487
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a summary of the proposed changes, describe tests and documentation, and review the acknowledgement below.
Summary
Include issues that are resolved by this pull request.
Improved method of setting check_valve on pipes. Validation and conversion from string values 'True', 'False', '1' and '0' occurs within element rather than with add_pipe. This means when check_valve is set directly validation will occur.
Contributres to #422. This is also a step towards allowing use of geopandas >= 1.0. This is because shapefile booleans seem to be returned as strings 'True' and 'False' rather than strings '1' and '0' so current normalisation with
check_valve = bool(int(check_valve))
fails. This resolves the following error when trying to use geopandas >= 1.0May also fix #475
Tests and documentation
Does not change the API functionality, covered by existing tests.
Acknowledgement
By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.