Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model development demo #491

Open
wants to merge 49 commits into
base: main
Choose a base branch
from
Open

Model development demo #491

wants to merge 49 commits into from

Conversation

kaklise
Copy link
Collaborator

@kaklise kaklise commented Mar 20, 2025

This PR adds a new demo that creates a water network model using imperfect geospatial data

Summary

This PR includes the following updates

  • Added a Jupyter notebook model_development.ipynb that builds a water network model using imperfect geospatial data using files based on ky4
  • Added connect_lines function to connect geospatial lines that do not share endpoints. Line end points are connected if they fall within a user specified distance threshold. The function uses spipy linkage and fcluster.
  • Updated add_control to add a controls from a string in EPANET format (for example, "LINK Pump-1 OPEN IF NODE Tank-1 BELOW 10")
  • Bug fix in from_dict to include 0 as the default value for elevation

Tests and documentation

New documentation and test were added for the connect_line function.

Acknowledgement

By contributing to this software project, I acknowledge that I have reviewed the software quality assurance guidelines and that my contributions are submitted under the Revised BSD License.

dbhart and others added 30 commits September 18, 2024 14:14
Update to geospatial to get elevations from nearest neighbors when elevation data is missing

Added demonstration geojson files with KY4 misaligned pipes and decimated junction list.
Merge main into network gen branch
Updates to the model development notebook
@coveralls
Copy link

Coverage Status

coverage: 81.773% (-0.02%) from 81.788%
when pulling b4c5fea on kaklise:network-gen
into 20f4101 on USEPA:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants