Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cypress testing #121

Open
wants to merge 91 commits into
base: develop
Choose a base branch
from
Open

Feature/cypress testing #121

wants to merge 91 commits into from
+15,560 −1,096

Conversation

cschwinderg
Copy link
Contributor

Adds cypress automated tests and code coverage.

Notes:

  • Added /* istanbul ignore next: cannot test */ flags before some instances of code that cannot be tested (i.e., reportWebVitals and unhandled exceptions). This improves the code coverage numbers.
  • Added a retries flag to the cypress config. This makes cypress retry a test if it fails.
    • I ran into issues on Step 5 where when the district id is entered sometimes the rest of the form is not auto populated. I also added some waits around entering the district id. I've never encountered this issue when manually filling out the form, so it must be something to do with how fast cypress fills out the forms.
    • This flag has also been helpful for other situations where a test randomly fails.
  • Added Cypress.on('uncaught:exception',... to the top of all of our .spec.js files. This makes it so that cypress does not fail tests when there are errors in the chrome developer console. I put a todo comment to remind us to remove this code when the app is more stable. The screenshot below shows the error message that usually causes tests to fail.

image

cschwinderg added 30 commits April 1, 2022 14:58
@cschwinderg
Added in the cypress and coverage packages.
fa7da62
@cschwinderg
Added in a basic test.
550d475
@cschwinderg
Added a reusable login command and an authentication test.
c6cf709
@cschwinderg
Merge branch 'develop' into feature/cypress-testing
8aa44ae 
# Conflicts:
#	app/client/src/components/welcome.tsx
@cschwinderg
Fixed issues with cypress tests after merge.
7f2ad28
@cschwinderg
Merge branch 'develop' into feature/cypress-testing
7f236a1 
# Conflicts:
#	app/client/src/components/welcome.tsx
@cschwinderg
Merge branch 'develop' into feature/cypress-testing
5d7f438
@cschwinderg
Merge branch 'develop' into feature/cypress-testing
6541b73
@cschwinderg
Merge branch 'develop' into feature/cypress-testing
cc17618
@cschwinderg
Merge branch 'develop' into feature/cypress-testing
2d86bd1
@cschwinderg
Added a test for filling out the application.
658cb38
@cschwinderg
Added more authentication tests.
1e382b2
@cschwinderg
Fixed issue of code coverage missing files in output.
dd91fdd
@cschwinderg
Added some more tests.
4eedec4
@cschwinderg
Merge branch 'develop' into feature/cypress-testing
eaf8bf3
@cschwinderg
Updated the service routes, since v1 was removed. Refactored the reba…
c0d4f4e 
…te-form tests.
@cschwinderg
Added some more tests and ran prettier.
6ecd245
@cschwinderg
Merge branch 'develop' into feature/cypress-testing
1e350e5
@cschwinderg
Fixed tests after merge.
d18db9f
@cschwinderg
Merge branch 'develop' into feature/cypress-testing
070fe05
@cschwinderg
Added flag to ignore the reportWebVitals.ts file in cypress tests.
e9b5920
@cschwinderg
Added some more lines to ignore code coverage.
1e71374
@cschwinderg
Merge branch 'develop' into feature/cypress-testing
052d0ba
@cschwinderg
Merge branch 'develop' into feature/cypress-testing
94e4912
@cschwinderg
Updated cypress tests to use preferred cypress coding practices.
57a780c
@cschwinderg
Removed only flag.
e1cf32f
@cschwinderg
Added some new tests for the helpdesk.
7dbf0a6
@cschwinderg
Fixed an issue with running all of the tests at once.
aa06976
@cschwinderg
Fixed rebate form tests.
ad39ed0
@cschwinderg
Fixed routes tests.
6943e1d
@cschwinderg cschwinderg mentioned this pull request Apr 26, 2022
Merged
cschwinderg and others added 18 commits April 26, 2022 11:54
@cschwinderg
Merge branch 'develop' into feature/cypress-testing
6f6f1c7 
# Conflicts:
#	app/client/src/routes/allRebates.tsx
#	app/client/src/routes/helpdesk.tsx
#	app/client/src/routes/newRebate.tsx
@cschwinderg
Removed duplicate test and fixed step 4 since autopopulate on NCES ID…
582cf6a 
… was fixed.
@cschwinderg
Removed unnecessary packages.
dc7cb55
@cschwinderg
Fixed cypress tests.
24fb1e3
@cschwinderg
Added myself to the package.json files.
3453bed
@courtneymyers
Re-install @cypress/instrument-cra as a dependency to follow existing…
2560933 
… CRA conventions
@courtneymyers
Update orchestrating app's npm scripts to have better output for conc…
49aa047 
…urrently logs
@cschwinderg
Removed testing code for filling out form that should be filled out b…
86cfd3e 
…y NCES ID.
@courtneymyers
Update npm run scripts (while keeping cypress and coverage scripts se…
07862ce 
…parate)
@courtneymyers
Update npm coverage script to run all tests
93fbc3e
@cschwinderg
Fixed the tests.
e629b8d
@cschwinderg
Removed the readme file and prettier config. Re-ran prettier on all c…
ba3daf4 
…ypress files.
@cschwinderg
Updated the gitignore file to ignore cypress videos and screenshots.
5d401e1
@courtneymyers
Remove example cypress fixture and format config file
9197667
@cschwinderg
Switched as much as possible over to findByRole.
62b6c94
@cschwinderg
Fixed code smells.
ca2ab4c
@cschwinderg
Switched some more items over to findByRole and ran prettier on all o…
3e13c65 
…f the test files.
@cschwinderg
Fixed codesmells.
c4d06a0
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cschwinderg
Copy link
Contributor Author

cschwinderg commented May 10, 2022 •
edited
Loading

@courtneymyers I think I am done making the switch to findByRole. Below is a list of items that findByRole would not work for because they are not accessible. I'm not sure if you want to send something to the formio team about these items.

  • Docker Sign In Page (not really important since it is only accessible when running locally)
    • Password
  • Application Step 4
    • National Center for Education Statistics (NCES) District ID
    • State or Territory
  • Application Step 5
    • Model
    • Average Annual Fuel Consumption (gallons)
    • Replacement Bus GVWR (lbs.)
    • Manufacture - Uses a dropdown component that has search functionality. So this isn't a normal select input. I'm not really sure if there is anything they can do to fix this.
    • Fuel Type - Uses a dropdown component that has search functionality. So this isn't a normal select input. I'm not really sure if there is anything they can do to fix this.
    • Replacement Fuel Type - Uses a dropdown component that has search functionality. So this isn't a normal select input. I'm not really sure if there is anything they can do to fix this.
    • File Upload - Right now I have to select by cy.get("div[ref="fileDrop"]"), which may help pinpoint what element needs to be labeled.
  • Application Step 6
    • Sign Application - Right now I have to select by cy.get("canvas"), which may help pinpoint what element needs to be labeled.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgalloway dpgalloway Awaiting requested review from dpgalloway

@courtneymyers courtneymyers Awaiting requested review from courtneymyers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cschwinderg @courtneymyers