Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add bap query for 2023 submissions #375

Merged
merged 8 commits into from
Dec 8, 2023

Conversation

courtneymyers
Copy link
Collaborator

Related Issues:

  • CSBAPP-252

Main Changes:

  • Fetches submission data from the BAP for 2023 submissions to support showing BAP submission statuses on the user's dashboard for 2023 submissions.
  • Reduces a bit of duplicated code for combining submission data from the BAP and Formio that's now used for both 2022 and 2023 submissions.

Steps To Test:

  1. Create some FRF submissions for 2023
  2. Request the BAP team to change the status of a few submissions
  3. Ensure statuses are reflected as expected on the dashboard, along with all functionality related to statuses (e.g. "Edits Requested").

…update react-query hooks to fetch BAP data for 2023 submissions
…o data actually fetched for now – just stubbed out in the server app for now)
…022Submissions() and combine2023Submissions() functions, since most was duplicated anyway
… simplify sorting of form types by using common string each record type starts with (e.g. 'CSB Funding Request' which matches 2022 submissions of that name and 2023 submissions, which are named 'CSB Funding Request 2023')
@courtneymyers courtneymyers merged commit 13ea5a8 into develop Dec 8, 2023
1 of 2 checks passed
@courtneymyers courtneymyers deleted the feature/add-bap-query-for-2023-submissions branch December 8, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant