Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/update injected prf data #405

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Feature/update injected prf data #405

merged 2 commits into from
Mar 29, 2024

Conversation

courtneymyers
Copy link
Collaborator

Related Issues:

  • CSBAPP-275

Main Changes:

Fixes bugs in injected 2023 PRF data:

  • Fixes typo in "_bap_district_contact_id" field.
  • Fixes regression, due to Feature/update prf field names #404 – logic updated that builds up of unique orgs updated to reflect renamed "_org_id" field.

Steps To Test:

  1. Ask the BAP to change an existing 2023 FRF submission's status to "Accepted"
  2. Create a new 2023 PRF submission.
  3. Ensure the injected data is correct: particularly the school district contact id is shown, and there aren't duplicated orgs included in the "org_organizations" array.

@courtneymyers courtneymyers merged commit 3923d57 into develop Mar 29, 2024
1 check passed
@courtneymyers courtneymyers mentioned this pull request Apr 1, 2024
Merged
@courtneymyers courtneymyers deleted the feature/update-injected-prf-data branch April 17, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@courtneymyers