Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python static type checking #599

Merged
merged 10 commits into from
Oct 4, 2023
Merged

Python static type checking #599

merged 10 commits into from
Oct 4, 2023

Conversation

dpgraham4401
Copy link
Member

@dpgraham4401 dpgraham4401 commented Oct 4, 2023 •
edited
Loading

Description

This PR does less than it was supposed to initially, however it is in a state that can be merged to main since I'm OOO the next couple of days and there are some other things I need to take care of beforehand.

  1. Adds static type checking to our python code (incrementally). We're using mypy
    • We're doing this as it should ahve been included a while back, and in anticipations of the syntactic sugar improvements to type checking in python 3.12.
  2. implements a consistent logging pattern (sort of) and closes Consistent logging implementation #376

Issue ticket number and link

closes #376

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions github-actions bot added client Related to front end workings (React/Redux) dependencies project dependency problems or modifications documentation Improvements or additions to documentation server Related to backend workings (Django/Rest API) test Unit tests are, or need to be, included labels Oct 4, 2023
@dpgraham4401 dpgraham4401 merged commit 138af2f into USEPA:main Oct 4, 2023
9 checks passed
@dpgraham4401 dpgraham4401 deleted the python_static_type_checking branch October 4, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
client Related to front end workings (React/Redux) dependencies project dependency problems or modifications documentation Improvements or additions to documentation server Related to backend workings (Django/Rest API) test Unit tests are, or need to be, included
Projects
No open projects
Haztrak
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistent logging implementation
1 participant
@dpgraham4401