Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Technical debt repayment #632

Merged
merged 18 commits into from
Nov 2, 2023
Merged

Technical debt repayment #632

merged 18 commits into from
Nov 2, 2023

Conversation

dpgraham4401
Copy link
Member

@dpgraham4401 dpgraham4401 commented Nov 2, 2023 •
edited
Loading

Description

Just paying down som technical debt. involved working with the service modules and creating more uniform interfaces, moving logic out of our request handlers (views).

Issue ticket number and link

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@dpgraham4401
fix routing from most specific to least
45bd82c
@dpgraham4401
add check that manifest is not draft before saving to RCRAInfo
2f123df
@dpgraham4401
refactor CreateManifestView so that all logic is moved into our busin…
28294a5 
…ess logic and it now saves to the database if just a draft or launches a task and saves to RCRAInfo if not a draft
@dpgraham4401
revert docker and local virtual environment to python 3.11 until pyth…
73ffbd8 
…on 3.12 is fully supported by Celery
@dpgraham4401
refactor sync rcrainfo manifest services and tasks
08dba92
@dpgraham4401
refactor site services for pulling rcra sites from rcrainfo
2ee3001
@dpgraham4401
misc just savings work
1ecf42d
@dpgraham4401
update HandlerSearchView to follow styleguide and use class internal …
c3e7de1 
…serializer, switch DRF exception handling to match-case
@dpgraham4401
Cache all GET api views for at least 15 minutes
34b7a1b
@dpgraham4401
misc service method renames and add waste_services for retrieving was…
8154d32 
…te information
@dpgraham4401
add service function for getting DOT shipping information (hazard cla…
be9020c 
…ss, ID Numbers, Shipping name)
@dpgraham4401
add examples for DOT option lookup views
ea913ac
@dpgraham4401
move test_handler_service to sites app
d9d3c3d
@dpgraham4401
update test suite and conform quicker sign related function signatures
c9e33cd
@dpgraham4401
add test for waste service functions for retrieveing DOT lookup infro…
d43628a 
…mation
@dpgraham4401
clean up
0d7c1d3
@dpgraham4401
add unit test for ManifestService._filter_mtn method
3f008e0
@github-actions github-actions bot added CI/CD Requires modiciations to the continuous integration pipeline(s) client Related to front end workings (React/Redux) dependencies project dependency problems or modifications documentation Improvements or additions to documentation server Related to backend workings (Django/Rest API) test Unit tests are, or need to be, included labels Nov 2, 2023
@dpgraham4401 dpgraham4401 merged commit 14c77cd into USEPA:main Nov 2, 2023
8 checks passed
@dpgraham4401 dpgraham4401 deleted the technical_debt_repayment branch November 2, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI/CD Requires modiciations to the continuous integration pipeline(s) client Related to front end workings (React/Redux) dependencies project dependency problems or modifications documentation Improvements or additions to documentation server Related to backend workings (Django/Rest API) test Unit tests are, or need to be, included
Projects
No open projects
Haztrak
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dpgraham4401