Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor client side services #641

Merged
merged 11 commits into from
Nov 16, 2023

Conversation

dpgraham4401
Copy link
Member

@dpgraham4401 dpgraham4401 commented Nov 16, 2023

Description

This PR is just a pay off of some technical debt. It moved calls to our server API into a API layer or service modules. it also reorganizes the redux store exports so all exports come from the store root index.ts. This way the internals can change without the UI layer having to know about it.

Issue ticket number and link

closes #634

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@github-actions github-actions bot added the client Related to front end workings (React/Redux) label Nov 16, 2023
@dpgraham4401 dpgraham4401 merged commit 0ba9408 into USEPA:main Nov 16, 2023
5 checks passed
@dpgraham4401 dpgraham4401 deleted the refactor_client_side_services branch November 16, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Related to front end workings (React/Redux)
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

refactor client side logic into services
1 participant