Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long running task notifications #643

Merged
merged 9 commits into from
Nov 20, 2023

Conversation

dpgraham4401
Copy link
Member

Description

This PR adds UI enhancements that allows users to see the progress of long-running background tasks, often that interact with RCRAInfo. We do so by adding a new slice to our redux global state, exposing a new custom hook that allows the UI components to monitor the progress and display things accordingly. The global state also automatically displays toast through our new dependency react-toastify.

image

image

Issue ticket number and link

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

…ly for handling events like onClick and onClose handler)

add uuid dependency to auto generate UUIDs for client side created alerts, rename Notifications to Alerts to differentiate between alerts (to notify users of errors and short term messages) and messages or whatever we call them (server stored events that in the future will be retrievable)
all alerts are dispatched through our global state using react toastify. We can then manage the state of the alerts, rendering the alerts (toasts) is done auto-magically
…ofile UI when the long-running task is complete
…Tracker custom hook

control export from hooks and redux store module
test suite for notification slice
@github-actions github-actions bot added client Related to front end workings (React/Redux) dependencies project dependency problems or modifications infrastructure changes dealing with our deployment setup and IaC server Related to backend workings (Django/Rest API) test Unit tests are, or need to be, included labels Nov 20, 2023
@dpgraham4401 dpgraham4401 merged commit 6218596 into USEPA:main Nov 20, 2023
8 checks passed
@dpgraham4401 dpgraham4401 deleted the long_running_task_notifications branch November 20, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Related to front end workings (React/Redux) dependencies project dependency problems or modifications infrastructure changes dealing with our deployment setup and IaC server Related to backend workings (Django/Rest API) test Unit tests are, or need to be, included
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant