-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update manifest service #657
Merged
dpgraham4401
merged 10 commits into
USEPA:main
from
dpgraham4401:update_manifest_service
Dec 6, 2023
Merged
Update manifest service #657
dpgraham4401
merged 10 commits into
USEPA:main
from
dpgraham4401:update_manifest_service
Dec 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…including breaking changes with the mock service worker (MSW) with significant breaking changes
… with the other managers and Django/DRF's svae mthods) and an optional instance (to update) Rename serializer class files convert model manager save method to class method
… (as if it came from JSON) to pass to the model manager save method
…manifests from the haztrak database. the new service allows us to filter (optionally) by EPA ID and/or site type. replace logic in MtnListView with call to get_manifests service and add endpoint to MTN list category with site type parameter update names of trak and sites (django apps) views to be internally consistent use faker to mock manifest tracking numbers and create manifest_transporter_factory
…r filtering by status and a new MtnSearchField component. The new filter fields stores and reads the state in a URL search parameter. quick aria label fixes for MtnList
github-actions
bot
added
client
Related to front end workings (React/Redux)
database
changes that require modification to the database schema
dependencies
project dependency problems or modifications
server
Related to backend workings (Django/Rest API)
test
Unit tests are, or need to be, included
labels
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
client
Related to front end workings (React/Redux)
database
changes that require modification to the database schema
dependencies
project dependency problems or modifications
server
Related to backend workings (Django/Rest API)
test
Unit tests are, or need to be, included
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a relatively large PR. It adds the following to our project.
update_manifest
internal service. It currently just updates the manifest in our system. There is not an exposed view/handler..save()
method. We use our internalsave
method to abstract away the create/update process. It builds on existing Django ORM functionality.MtnListView
handler/view into a service module function that allows us to filter all manifest byepa_id
andsite_type
(for example, theget_manifest
service could return all manifests that the user has access to a site that is listed as a generator). I'm happy with the way this turned out, it follows the django-styleguide approach of placing business logic into our service modules.yield
withreturn
where appropriate in our factories as fixtures.Issue ticket number and link
Checklist