Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine org site apps #752

Merged
merged 18 commits into from
Jul 25, 2024
Merged

Combine org site apps #752

merged 18 commits into from
Jul 25, 2024

Conversation

dpgraham4401
Copy link
Member

Description

Combines the orgsite django app with the org app. the Site entity/model is now appart of the the organization app since there is no discernable boundary between the two concepts, a site cannot exists without an organization.

In addition, it removes the SiteAccess and OrgAccess models in favor of our new permission/roles implementation that makes use of django guardian.

PLEASE NOTE: ALL CONTRIBUTORS WILL NEED TO DROP THEIR DATABASE TO SPIN UP LOCAL DEVELOPMENT ENVIRONMENTS AFTER THIS PR... sorry.

Issue ticket number and link

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@dpgraham4401
remove apps directory
812c6a4
@dpgraham4401
fix fixture data and remove old settings for logger
36c0532
@dpgraham4401
remove sutom user/group object permission models
4981a29
@dpgraham4401
refactor SiteDetailsView to use get_object method
ca4898d
@dpgraham4401
add PermissionRequiredMixin to site details
dab76b2
@dpgraham4401
fix orgsite app url namespace and references
de30f65
@dpgraham4401
implement SiteObjectPermissions
5b1873c
@dpgraham4401
use guardian with SiteListView
3eb2179
@dpgraham4401
simplify OrgSiteListView
314ca05
@dpgraham4401
fix site model tests
643b79c
@dpgraham4401
simplify perm_factory fixture api
b6a56b6
@dpgraham4401
fix permissions in tests
1abd2e8
@dpgraham4401
remove site_access_factory fixture
eae5847
@dpgraham4401
remove SiteAccess model in favor of the django guardin equivalent imp…
75074e0 
…lementation
@dpgraham4401
combine orgsite and site django apps together
34733f4 
these two apps were so dependant on each other that there was not discernable boundary
@dpgraham4401
streamline org/site permission admin
fff6ac2
@dpgraham4401
remove OrgAccess model in favor of our django guardian implementation
836f154
@github-actions github-actions bot added server Related to backend workings (Django/Rest API) test Unit tests are, or need to be, included labels Jul 25, 2024
@dpgraham4401
Copy link
Member Author

closes #744
closes #746
closes #745

@dpgraham4401 dpgraham4401 merged commit 426c503 into USEPA:main Jul 25, 2024
6 checks passed
@dpgraham4401 dpgraham4401 deleted the combine_org_site_apps branch July 25, 2024 22:10
@dpgraham4401 dpgraham4401 mentioned this pull request Jul 25, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
server Related to backend workings (Django/Rest API) test Unit tests are, or need to be, included
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dpgraham4401