Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc Repo Chores #758

Merged
merged 12 commits into from
Aug 1, 2024
Merged

Misc Repo Chores #758

merged 12 commits into from
Aug 1, 2024

Conversation

dpgraham4401
Copy link
Member

Description

This PR is all over the place, it does several things that i've wanted to do.

  1. add health checks for our restful API in our compose
  2. reorganize the client application to follow the remix project structure.
    • this is part of getting ready to add organization URL parameter and use feature in react router and help up eventually migrate to RR v7.
  3. modify the collumns of the org and site object level permissions
  4. add fixtures so the local development test user has access
  5. modify imports in react client to use a root alias (from ~/*).

Issue ticket number and link

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@dpgraham4401
rename 'src' directory to 'app' directory to work with common framewo…
073c5ed 
…rk requirements
@dpgraham4401
move 'features' directory to 'routes' to work with remix project stru…
ceaed62 
…cture

we're not planning on migrating to Remix (give the news that remix is essentually being merged into react router v7) however, given this news, incrementally adopting more of the react reouter v6 features may help us take advantage of some of the useful features of remix when react router v7 comes out
@dpgraham4401
update tsconfig to use a remix vite spa template config
3a95af1
@dpgraham4401
modify imports to use alias imports
5832bc3
@dpgraham4401
rename 'test-utils' to mocks
281d97a
@dpgraham4401
modify mock service work import and conditional worker start up to fo…
912374e 
…llow current docks
@dpgraham4401
remove prettier configs from repo root
61ae277 
modify when mock browser is enabled to NODE_ENV='test'

move prettier configs to client directory to fox docker build
@dpgraham4401
move setupTest.ts to the mocks directory
810da24
@dpgraham4401
rename org and site object permission columns names to clarify that t…
3705c2f 
…he content_object_id is the object ID of a site\/org object

also add development fixtures so our test user has the appropriate permissions
@dpgraham4401
modify pre-commit prettier files arg
aac7c28
@dpgraham4401
modify dev fixtures
0fdf254
@dpgraham4401
add health checks to our trak (RESTful API) service in our docker com…
3c0c82a 
…pse file
@github-actions github-actions bot added CI/CD Requires modiciations to the continuous integration pipeline(s) client Related to front end workings (React/Redux) documentation Improvements or additions to documentation server Related to backend workings (Django/Rest API) labels Aug 1, 2024
@dpgraham4401 dpgraham4401 merged commit 4b5e311 into USEPA:main Aug 1, 2024
9 checks passed
@dpgraham4401 dpgraham4401 deleted the app_structure_reorg branch August 1, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI/CD Requires modiciations to the continuous integration pipeline(s) client Related to front end workings (React/Redux) documentation Improvements or additions to documentation server Related to backend workings (Django/Rest API)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dpgraham4401