-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
derive an M matrix for IEF models #317
Conversation
Leaving this as draft for now as it may require further discussion. |
A few notes about this approach:
|
And this is especially clear for the flows not available in the IEFs which are identical for |
@WesIngwersen see the commit above which is using ratios from the domestic production demand vector relative to the import consumption demand vector, which I'm not sure is quite right still |
Yes i reviewed the approach and its still problematic, perhaps due to differences in the demand vectors as well as the negatives present which mess up ratios. I propose more of a weighted average approach, using commodity output, q and the total imports m |
Have you made any scripts for testing this with different models? |
The automated model builds include But no I haven't done an external script to do that explicitly - are there certain validations that we want to test after building the M this way? |
Make sure each value is in between the respective value in M_m and M_d. To do this might need to get max and min matrices |
the detail model is failing for S00900 Rest of World Adjustment. |
That's OK, that should not be an issue - we always have exceptions with RoW adjustment since its an accounting correction row and meaningless for use in the model. thanks I assume this check passes for some state models and the summary model? |
ok I'll change this from a stop to a print statement or something like that as a form of validation, not a requirement
I need to check - the other models may not have run on the action when the detail model failed, but yes I tested this with those models as well and it should work. |
OK I think we can proceed with updating N and related vars using this new M |
by building Lines 72 to 83 in e232ca1
|
We will need to decide if this is going to be integrated with v1.6.1 (CBEI model release) or wait until v1.7 |
Bring this in w/ v1.6.1 as it will be described in the CBEI report. |
When an M matrix is present an N matrix will also be constructed during the regular course of model build.