Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

Python plotting scripts #184

Closed
jsadler2 opened this issue Dec 21, 2022 · 3 comments · Fixed by #224
Closed

Python plotting scripts #184

jsadler2 opened this issue Dec 21, 2022 · 3 comments · Fixed by #224

Comments

@jsadler2
Copy link
Collaborator

I have some plotting scripts that I've been using.
Some of these are substitutes to the R functionality #180.

I'm not sure the best way forward.
I'm much more comfortable in Python.
You guys are more comfortable in R.
Eventually we will need to decide on one or the other for the manuscript figures, but I think for now it can make sense to just keep doing what we are comfortable with.

@galengorski
Copy link
Collaborator

Just to chime in, for the estuary salinity paper, I have figures from both python and R in the manuscript. I've edited them to look similar, but for me, that was easier than deciding on one plotting language. Here is a link to the figures if you want to take a look, some had to be slightly edited in illustrator. Just an option if we want to punt on this decision...

@jsadler2
Copy link
Collaborator Author

Thanks, Galen. That's helpful to know that that is the direction you all took and it worked out okay

@lekoenig
Copy link
Collaborator

I have some plotting scripts that I've been using.
Some of these are substitutes to the R functionality #180.

There are a few ways to slice the data in this pipeline (e.g. partition/model id/site id/etc). So to a certain extent, in this semi-exploratory phase I actually think it's a nice gut-check that we've drafted the same type of figure independently and get the same results/draw the same conclusions 🙂

If there are figures that we commonly refer to, I think it's worth checking the code that creates them into version control, even if not formally integrated in either the targets or snakemake parts of the pipeline. Once we decide on the set of figures we want for the manuscript, we can add those into the pipeline (R or python probably depending on who creates the publication-quality version of each figure). Just my 2 cents.

jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Dec 30, 2022
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Dec 30, 2022
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Dec 30, 2022
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Dec 30, 2022
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Dec 30, 2022
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Dec 30, 2022
reorder models, mark val sites
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Apr 6, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Apr 6, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Apr 6, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Apr 6, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Apr 6, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Apr 6, 2023
reorder models, mark val sites
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Apr 6, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue May 15, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue May 15, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue May 15, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue May 15, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue May 15, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue May 15, 2023
reorder models, mark val sites
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue May 15, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue May 15, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue May 15, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Jul 31, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Jul 31, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Jul 31, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Jul 31, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Jul 31, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Jul 31, 2023
reorder models, mark val sites
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Jul 31, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Jul 31, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Jul 31, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Jul 31, 2023
revising plotting pred performance
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Jul 31, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Aug 21, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Sep 7, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Sep 7, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Sep 7, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Sep 7, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Sep 7, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Sep 7, 2023
reorder models, mark val sites
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Sep 7, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Sep 7, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Sep 7, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Sep 7, 2023
revising plotting pred performance
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Sep 7, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Sep 7, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Sep 7, 2023
jsadler2 added a commit to jsadler2/drb-do-ml that referenced this issue Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants