Add timeseries scrolly frames #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK this works but I am concerned we are overcomplicating this piece of the page. The axis labels, titles, and labels are not going to be visible at this scale, especially with this many panels, and it definitely won't play on mobile. Before we move ahead and implement this into the website I think it is necessary to sketch out how that is going to work. OK to merge but cautious about the next steps of implementation. |
cnell-usgs
approved these changes
Sep 8, 2022
|
Completely agree with the criticisms of the frame's current state. My interpretation of why this PR was submitted was to get you frames and associated text to work with while I continued to work on the actual visual updates of those frames. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the frames that can be inserted into the website. The individual charts are generated by the pipeline and then I manually saved in these PNGs that represent the states at various points in the scrollytelling section. I also added the
src/assets/text/timeseriesScrollyText.jsfile modeled off of this file from Althea in the drought explainer.Note that these figs are plotting "rolling 10-day mean temperature" and "daily maximum dissolved oxygen", even though the labels don't convey that. I realized it after I created these, but I know they need to be updated later anyways.