Skip to content

Conversation

@NickleDave
Copy link
Contributor

Description

Adding abstract provided by @MarsBarLee 🎉

Motivation and Context

Replaces "abstract will be added", and adds some links

Checklist:

  • I have posted the link for the PR in the usrse slack (#website) to ask for reviewers
    will do
  • I have previewed changes locally
    will preview on Circle CI
  • I have updated the README.md if necessary
    n/a

cc @usrse-maintainers

@NickleDave NickleDave force-pushed the add-abstract-mars-lee-talk branch from 03e3a94 to d915ba5 Compare November 12, 2022 16:57
@NickleDave
Copy link
Contributor Author

Force pushed some tweaks.
Waiting for feedback from the speaker via email so please don't merge just yet 🙏 if by chance you are working on the weekend

@mtbc
Copy link
Contributor

mtbc commented Nov 13, 2022

so please don't merge just yet

Probably good to switch it to being a draft PR until you're okay with merging.

@NickleDave NickleDave marked this pull request as draft November 13, 2022 18:22
@NickleDave
Copy link
Contributor Author

Thanks @mtbc, done. Will make draft PRs in the future for similar situations

Copy link
Contributor

@mrmundt mrmundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like Oxford-commas, but besides that, looks good.

@mrmundt
Copy link
Contributor

mrmundt commented Nov 14, 2022

@NickleDave - Poke me when it's good to merge! Ian spread the love and put the review-and-approve-and-merge powers on me. (Probably retribution for contributing to the PR game the other day...)

@NickleDave NickleDave requested a review from mrmundt November 14, 2022 14:53
@mrmundt mrmundt marked this pull request as ready for review November 14, 2022 16:57
@mrmundt mrmundt merged commit 9d4917f into USRSE:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants