Added modules pages for Membership check, events, login,involvement. Added apis for membership check and login. Integrated Dev Link API #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Added apis for membership check and login. Integrated Dev Link API
ludvigalden
suggested changes
Jan 29, 2024
There was a problem hiding this comment.
Well done, but there is a lot of duplicate code and mismatches with the front-end branch. So I won't be able to merge anything into the front-end branch before they are "in sync". For now, I added the changes with fixes to commit b8cf5ba and #788. I did not include the log-in page because it should be structured very differently, since the authentication should be synced between all pages and you should be able to log in and sign up in all three modules (member, involvement, event), we need some authentication context, automatic token refresh, and so on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
I have added modules pages for Membership check, events, login, and involvement. Added APIs for membership check and login. Integrated Dev Link API
Applicable Issues
The login button does not do anything for now. I will be adding a toast and redirect on successful login.