Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linked Lists #11

Merged
merged 9 commits into from
Oct 2, 2024
Merged

Linked Lists #11

merged 9 commits into from
Oct 2, 2024

Conversation

aviralgarg05
Copy link
Contributor

@aviralgarg05 aviralgarg05 commented Oct 1, 2024

Pull Request for PyVerse 💡

Issue Title : Linked Lists

  • Info about the related issue (Aim of the project) : Linked lists are a fundamental data structure that allows efficient storage and manipulation of data and learn about it.
  • Name: Aviral Garg
  • GitHub ID: aviralgarg05
  • Email ID: [email protected]
  • Idenitfy yourself: (Mention in which program you are contributing in. Eg. For a WoB 2024 participant it's, WoB Participant) GSSOC 24' Extended

Closes: #issue number that will be closed through this PR
#7

Describe the add-ons or changes you've made 📃

Created a Linked Lists algorithm for Data Structures
Give a clear description of what have you added or modifications made
Created a Linked Lists algorithm for Data Structures

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Describe how it has been tested: - Outputs have been clearly mentioned
Describe how have you verified the changes made:- Runtime and Correct outputs

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

github-actions bot commented Oct 1, 2024

👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

@github-actions github-actions bot requested a review from UTSAVS26 October 1, 2024 16:21
@UTSAVS26
Copy link
Owner

UTSAVS26 commented Oct 1, 2024

@aviralgarg05 please add comments in the code too in this format

def <function_name>():

<Brief description of the function's purpose.>

Args:
    <parameter_name> (<parameter_type>): <Description of the parameter.>

Returns:
    <return_type>: <Description of the return value.>

Example:
    >>> <function_name>(<example_input>)
    <example_output>

# Function logic here

Copy link
Owner

@UTSAVS26 UTSAVS26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes required

@UTSAVS26 UTSAVS26 added invalid This doesn't seem right Status: Requested Changes Indicates that a reviewer has requested changes to a PR before it can be approved. labels Oct 1, 2024
Copy link
Collaborator

@TheChaoticor TheChaoticor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in comments required as suggested by the PA

@aviralgarg05
Copy link
Contributor Author

Changes requested are made

@UTSAVS26 UTSAVS26 merged commit 9ecc2bc into UTSAVS26:main Oct 2, 2024
@UTSAVS26 UTSAVS26 added Status: Approved PRs that have passed review and are approved for merging. level1 gssoc-ext hacktoberfest-accepted and removed invalid This doesn't seem right Status: Requested Changes Indicates that a reviewer has requested changes to a PR before it can be approved. labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext hacktoberfest-accepted level1 Status: Approved PRs that have passed review and are approved for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants