Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Improved & fixed the QR_GUI application #833

Closed
wants to merge 1 commit into from

Conversation

yashksaini-coder
Copy link
Contributor

Pull Request for PyVerse 💡

Requesting to submit a pull request to the PyVerse repository.


Issue Title

Please enter the title of the issue related to your pull request.
🐛Bug Fix: Improper QR_GUI implementation

  • I have provided the issue title.

Info about the Related Issue

What's the goal of the project?
PyVerse is an open-source collection of diverse Python projects, tools, and scripts, ranging from beginner to advanced, across various domains like machine learning, web development, and automation.

  • I have described the aim of the project.

Name

Please mention your name.
Yash K. Saini

  • I have provided my name.

GitHub ID

Please mention your GitHub ID.
yashksaini-coder

  • I have provided my GitHub ID.

Email ID

Please mention your email ID for further communication.
[email protected]

  • I have provided my email ID.

Identify Yourself

Mention in which program you are contributing (e.g., WoB, GSSOC, SSOC, SWOC).
GSSoC- Ext

  • I have mentioned my participant role.

Closes

Enter the issue number that will be closed through this PR.
Closes: #815

  • I have provided the issue number.

Describe the Add-ons or Changes You've Made

Give a clear description of what you have added or modified.

This pull request refactors the QR code generator application to improve its structure and user experience. The changes include organizing the code into a class, adding error handling, and enhancing the UI.

Code structure improvements:

  • Refactored the application into a QRCodeGenerator class to encapsulate functionality and improve code organization. (Beginner_Projects/QR Generator/QR_code_generator_GUI.py)

UI enhancements:

  • Added input validation and error messages using messagebox to improve user feedback. (Beginner_Projects/QR Generator/QR_code_generator_GUI.py)
  • Introduced a method to clean up temporary files after QR code generation to ensure no leftover files. (Beginner_Projects/QR Generator/QR_code_generator_GUI.py)

Functionality improvements:

  • Added a confirmation dialog to handle file overwrites when downloading QR codes. (Beginner_Projects/QR Generator/QR_code_generator_GUI.py)
  • Included a method to switch between light and dark themes dynamically. (Beginner_Projects/QR Generator/QR_code_generator_GUI.py)
  • I have described my changes.

Type of Change

Select the type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe how your changes have been tested.
Describe your testing process here.

  • I have described my testing process.

Checklist

Please confirm the following:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly!

Feel free to join our community on Discord to discuss more!

@yashksaini-coder
Copy link
Contributor Author

@UTSAVS26 can you review this PR, and add proper logic to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛Bug Fix: Improper QR_GUI implementation
1 participant