install chrome and delete chrome .deb #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Tejashreenk I believe I've mentioned before that all PRs should include descriptions of what they do. Please add. |
|
The commits included in this PR seem to do much more than just install chrome and delete the |
|
dart analyze ., flutter analyze . gives some errors due to print statements and unused imports. I have fixed it in this PR by using logger package |
|
The switch from print to logging would be good to mention in revised PR description. |
|
Closing this PR without merge because we agreed in team meeting today to pursue a non-Chrome based approach to integration testing. That approach does not require this addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding layer of chrome in docker image and deleting chrome .deb. Refining the code to solve linter test errors and using logger package to switch from switch from print to logging.