Create waypoint dictionary for Lap locations #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 10, 2024 15:22
… waypoint; Created lap waypoint list; Renamed mentions to generic waypoints to named waypoint / waypoint_names
mgupta27
reviewed
Mar 11, 2024
2024/waypoints/waypoint_task_1.csv
Outdated
Comment on lines
2
to
5
| Alpha,48.5112750,-71.6505486 | ||
| Bravo,48.5058636,-71.6322229 | ||
| Landing,48.5103379,-71.6472006 |
There was a problem hiding this comment.
Can we get rid of these changes. We only need to know the waypoint Alpha because when the drone takes off, it will need to fly to waypoint Alpha, then run laps.
path_2024_task_1.py
Outdated
| @@ -9,7 +9,8 @@ | |||
| from modules import waypoints_dict_to_list | |||
|
|
|||
|
|
|||
| WAYPOINT_FILE_PATH = pathlib.Path("2024", "waypoints", "waypoint_task_1.csv") | |||
| WAYPOINT_NAMES_FILE_PATH = pathlib.Path("2024", "waypoints", "waypoint_task_1.csv") | |||
There was a problem hiding this comment.
Can we rename file to takeoff_waypoint_task_1.csv
path_2024_task_1.py
Outdated
| @@ -9,7 +9,8 @@ | |||
| from modules import waypoints_dict_to_list | |||
|
|
|||
|
|
|||
| WAYPOINT_FILE_PATH = pathlib.Path("2024", "waypoints", "waypoint_task_1.csv") | |||
| WAYPOINT_NAMES_FILE_PATH = pathlib.Path("2024", "waypoints", "waypoint_task_1.csv") | |||
| LAP_WAYPOINT_FILE_PATH = pathlib.Path("2024", "waypoints", "lap_waypoint_task_1.csv") | |||
There was a problem hiding this comment.
Can we rename to lap_waypoints_task_1.csv
path_2024_task_1.py
Outdated
| # Create waypoint name to coordinate dictionary | ||
| result, waypoint_dictionary = \ | ||
| # Create waypoint name to coordinate dictionary for named waypoints | ||
| result, waypoint_names_dictionary = \ |
There was a problem hiding this comment.
Can we rename to takeoff_waypoint_dictionary.
path_2024_task_1.py
Outdated
| # Convert waypoint dictionary to list | ||
| result, waypoint_list = \ | ||
| # Convert named waypoint dictionary to list | ||
| result, waypoint_names_list = \ |
There was a problem hiding this comment.
Rename to waypoint_takeoff_list
mgupta27
approved these changes
Mar 12, 2024
| @@ -9,7 +9,8 @@ | |||
| from modules import waypoints_dict_to_list | |||
|
|
|||
|
|
|||
| WAYPOINT_FILE_PATH = pathlib.Path("2024", "waypoints", "waypoint_task_1.csv") | |||
| TAKEOFF_WAYPOINT_FILE_PATH = pathlib.Path("2024", "waypoints", "takeoff_waypoint_task_1") | |||
There was a problem hiding this comment.
Nit: Should it be takeoff_waypoint_task_1.csv?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Bravo, takeoff and landing to waypoint CSV