Added timeout variable to path_2024.py
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trotyl15
approved these changes
Mar 15, 2024
path_2024.py
Outdated
| @@ -32,7 +33,7 @@ def run() -> int: | |||
| Reads in hardcoded waypoints from CSV file and sends drone commands. | |||
| """ | |||
| # Wait ready is false as the drone may be on the ground | |||
| drone = dronekit.connect(CONNECTION_ADDRESS, wait_ready = False) | |||
| drone = dronekit.connect(CONNECTION_ADDRESS, wait_ready = False, timeout = TIMEOUT) | |||
There was a problem hiding this comment.
If we set wait_ready to False than the timeout here doesn't do anything. but yea it would help if we want to set wait_ready back to True in the future.
Trotyl15
reviewed
Mar 15, 2024
path_2024.py
Outdated
| @@ -23,6 +23,7 @@ | |||
| KML_FILE_PREFIX = "waypoints_log" | |||
| DELAY = 0.1 # seconds | |||
| MAXIMUM_FLIGHT_TIME = 1800 # seconds | |||
| TIMEOUT = 30 | |||
There was a problem hiding this comment.
Nit: add a comment like # seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added timeout variable to
path_2024.py