New branch after rebasing for evaluator module, based on PR #43 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code is pretty much identical to this pull request here: #43, rebasing gave me a lot of grief though so I created this new branch. |
mgupta27
reviewed
Apr 6, 2024
path_2024.py
Outdated
Comment on lines
91
to
100
| result, time_condition = mission_time_condition.MissionTimeCondition.create( | ||
| start_time, MAXIMUM_FLIGHT_TIME | ||
| ) | ||
|
|
||
| if not result: | ||
| print("Error: Mission time condition") | ||
| return -1 | ||
|
|
||
| return_to_launch_evaluator = condition_evaluator.ConditionEvaluator([time_condition]) | ||
|
|
There was a problem hiding this comment.
Sorry for the confusion, path_2024.py runs task 2 code. Since this is being tested I don't want to make any changes to it. Can we revert the changes to this file and bring back check_stop_condition.py.
Also, we want to incorporate this module into path_2024_task_1.py instead. Can you put the mission_time_condition there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.