Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload Waypoints + DO_JUMP Commands to Mission Planner #57

Merged
merged 3 commits into from
Apr 7, 2024
Merged

Upload Waypoints + DO_JUMP Commands to Mission Planner #57

merged 3 commits into from
Apr 7, 2024

Conversation

mgupta27
Copy link
Collaborator

@mgupta27 mgupta27 commented Apr 7, 2024

Upload Waypoints + DO_JUMP Commands to Mission Planner

Key Changes

  • Changed Lap 1 Waypoints
  • Created do_jump function in generate_command module
  • Uploaded waypoint commands and do jump command in path_2024_task_1.py
  • Fixed bug in add_takeoff_and_rtl_command
    • Switched from append function to insert(-1, ...)

@mgupta27 mgupta27 self-assigned this Apr 7, 2024
Trotyl15
Trotyl15 approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@Trotyl15 Trotyl15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2024/waypoints/lap_waypoints_task_1.csv Show resolved Hide resolved
@mgupta27 mgupta27 force-pushed the mihir.create-task-1-wp branch from be945c1 to 62e649e Compare April 7, 2024 22:17
@mgupta27 mgupta27 requested a review from Trotyl15 April 7, 2024 22:38
Trotyl15
Trotyl15 approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@Trotyl15 Trotyl15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mgupta27 mgupta27 merged commit a588955 into main Apr 7, 2024
1 check passed
@mgupta27 mgupta27 deleted the mihir.create-task-1-wp branch April 7, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trotyl15 Trotyl15 Trotyl15 approved these changes

@TongguangZhang TongguangZhang Awaiting requested review from TongguangZhang

@AaronWang04 AaronWang04 Awaiting requested review from AaronWang04

Assignees

@mgupta27 mgupta27

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgupta27 @Trotyl15