Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Altitude to Task 2 #58

Merged
merged 16 commits into from
Apr 21, 2024
Merged

Add Altitude to Task 2 #58

merged 16 commits into from
Apr 21, 2024

Conversation

mgupta27
Copy link
Collaborator

Add Altitude to Task 2

  • Changed the Task 2 CSV file to include altitudes
  • Created LocationGroundAndAltitude class to store the location ground and the altitude
  • Created new modules to read the LocationGroundAndAltitude and upload it to the drone
  • Updated test cases

Copy link
Contributor

@AaronWang04 AaronWang04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some nitpicks

__repr__(): Returns a string representation of the LocationGroundAndAltitude object.
"""

def __init__(self, name: str, latitude: float, longitude: float, altitude: float):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> None

should also fix the linter issue

from .common.kml.modules import location_ground


class LocationGroundAndAltitude:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a better name for this class, maybe WaypointCoordinate?

@mgupta27 mgupta27 merged commit 0506fe1 into main Apr 21, 2024
1 check passed
@mgupta27 mgupta27 deleted the mihir.add-altitude-task-2 branch April 21, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants