use paper-toolbar in air client #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, this one small part of #2815, to get me used to working on this UX stuff. |
jab
reviewed
Nov 28, 2016
| <paper-icon-button icon="menu"></paper-icon-button> | ||
| <span class="title">uProxy</span> | ||
| </paper-toolbar> | ||
| </div> |
There was a problem hiding this comment.
Is the wrapping <div class='paper-header'> superfluous now?
There was a problem hiding this comment.
Yes! paper-header-panel explicitly special-cases paper-toolbar:
https://elements.polymer-project.org/elements/paper-header-panel
Removed, thanks!
|
one tiny comment but this looks great, merge away! |
|
What goes in the menu? |
|
Judging from the mocks, it will be the settings panel. I was also using this as an exercise to become familiar with the web components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the current placeholder titlebar with Polymer's
paper-toolbarelement:https://elements.polymer-project.org/elements/paper-toolbar?view=demo:demo/index.html&active=paper-toolbar
I checked with UX and, background colour excepted, they're okay with the default height, etc., stylings.
This change is