-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimized Non-Conservative Zonal Average #1180
base: main
Are you sure you want to change the base?
Optimized Non-Conservative Zonal Average #1180
Conversation
…rties to grid
…es_xyz)`
@@ -1407,25 +1466,14 @@ def _populate_bounds( | |||
""" | |||
|
|||
# Ensure grid's cartesian coordinates are normalized | |||
# TODO: Is it possible to have a more flexible normalization? (Avoid duplicated normalizations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ philipc2 Can we avoid duplicate normalization here? For example if the nodes are already normalized, we will not normalize them.
For example, set an attributes in the grid node_x
,node_y
,node_z
to indicate if they're already normalized or not.
ASV Benchmark failing? |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
use utils instead of arcs
use utils instead of arcs
The benchmark still doesn't work out for this PR, can you take a look? Thanks |
Closes #1181 #880
Overview
zonal.py
Expected Usage
PR Checklist
General
Testing
Documentation
_
) and have been added todocs/internal_api/index.rst
docs/user_api/index.rst
Examples
docs/examples/
folderdocs/examples.rst
toctreedocs/gallery.yml
with appropriate thumbnail photo indocs/_static/thumbnails/