Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo scripts #215

Open
wants to merge 3 commits into
base: noetic-devel
Choose a base branch
from
Open

Demo scripts #215

wants to merge 3 commits into from

Conversation

MoffKalast
Copy link
Contributor

@MoffKalast MoffKalast commented Jul 28, 2022

Moved from #213 and added the actual files it references, so we can review the entire thing.

To put it clearly, seems like patch-6 is the code, patch-7 is just the readme, so I've merged 7 into 6 and this is the PR for 6 into noetic-devel.

anfederman and others added 3 commits July 19, 2022 09:51
Adding demo files to magni_nav  these have been tested, in gazebo/rviz   and work as well on a robot once a pathced move_base launch which creates a blank map is used.
@MoffKalast
Copy link
Contributor Author

Given this problem I would suggest to instead of using rosrun, we move the scripts to their own launch files and also include the move_base launch there. It should also conveniently serve as a demo of how to set up launch files with parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants