Skip to content

Commit

Permalink
- Added unit test for item selectio logic. More tests will come in a …
Browse files Browse the repository at this point in the history
…follow up PR

- Update Gradle to use Java 17 Temurin, AGP to use 8.4, kotlin to 1.9.24
- Renamed the module package name
- Renamed the module to indicate the actual purpose of the component is to help with NumberPicker
- Committin the versions used through xmls
- releaseUnitTest task was failing all the time with class not found error. Something in project config is causing the issue. So, created a new module and moved all the code, carefully updated all required versions. Then the issue is gone.
  • Loading branch information
UdaySravanK committed May 19, 2024
1 parent 09f487e commit 713cc1a
Show file tree
Hide file tree
Showing 27 changed files with 246 additions and 566 deletions.
22 changes: 22 additions & 0 deletions .idea/androidTestResultsUserPreferences.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .idea/gradle.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .idea/kotlinc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .idea/misc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

252 changes: 0 additions & 252 deletions .idea/other.xml

This file was deleted.

11 changes: 6 additions & 5 deletions JCItemPickerDemo/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,17 @@ android {
}
}
compileOptions {
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}
kotlinOptions {
jvmTarget = "1.8"
jvmTarget = "17"
}
buildFeatures {
compose = true
}
composeOptions {
kotlinCompilerExtensionVersion = "1.5.1"
kotlinCompilerExtensionVersion = "1.5.14"
}
packaging {
resources {
Expand All @@ -60,7 +60,8 @@ dependencies {
implementation(libs.androidx.ui.tooling.preview)
implementation(libs.androidx.material3)
implementation(libs.kotlinx.collections.immutable)
implementation(project(":jcitempicker"))
implementation(project(":JCNumberPicker"))

testImplementation(libs.junit)
androidTestImplementation(libs.androidx.junit)
androidTestImplementation(libs.androidx.espresso.core)
Expand Down
Loading

0 comments on commit 713cc1a

Please sign in to comment.