Skip to content

Commit

Permalink
FIxed all warnings from running tests (#152)
Browse files Browse the repository at this point in the history
* Added a test case for the new custom title prop
* Fixed all wrap in act warnings from the tests.
* We need to use waitFor to get the getByTestId callback ready after render.
* Removed the deprecated react-test-library
* Wrapped simple fire events in act and async events in async act
* Used fake timers to set the time out value of 5000
* Fixed same warnings for snapshot tests as well.

* Fixed a test failing on CI by increasing the timeout for first test
  • Loading branch information
UdaySravanK authored Mar 1, 2025
1 parent 4562a8b commit ce5a45f
Show file tree
Hide file tree
Showing 11 changed files with 721 additions and 474 deletions.
7 changes: 7 additions & 0 deletions .github/ISSUE_TEMPLATE/pull-reqeust.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,10 @@ assignees: ''

### Screenshots And/Or GIFs
<!-- Please attach screenshots of before fix and after fix -->

### Checks

[] Added or updated tests
[] Added or updated type definitions (in alphabetical order)
[] Updated readme file
[] Tested manually with demo app or with an other apporach
3 changes: 2 additions & 1 deletion LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
MIT License

Copyright (c) 2019 Uday Sravan Kumar Kamineni
Copyright (c) 2024 Uday Sravan Kumar Kamineni

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand All @@ -19,3 +19,4 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

1 change: 0 additions & 1 deletion docs/_config.yml

This file was deleted.

145 changes: 0 additions & 145 deletions docs/index.html

This file was deleted.

27 changes: 11 additions & 16 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@
"slide"
],
"author": "Uday Sravan Kumar Kamineni",
"maintainers": [
"UdaySravanK"
],
"contributors": [
"UdaySravanK"
],
"license": "MIT",
"bugs": {
"url": "https://github.com/UdaySravanK/RNSwipeButton/issues"
Expand All @@ -52,7 +58,6 @@
"@testing-library/react-native": "^12.8.1",
"@tsconfig/react-native": "^2.0.2",
"@types/jest": "^29.5.14",
"@types/react-test-renderer": "^18.3.0",
"babel-jest": "^29.7.0",
"eslint": "^8.57.0",
"eslint-plugin-react": "^7.34.2",
Expand All @@ -61,7 +66,6 @@
"jest": "^29.7.0",
"metro-react-native-babel-preset": "^0.77.0",
"pretty-quick": "^2.0.1",
"react-test-renderer": "^18.3.1",
"stylelint-config-prettier": "^8.0.1",
"stylelint-prettier": "^1.1.2",
"ts-jest": "^29.2.5",
Expand Down
Loading

0 comments on commit ce5a45f

Please sign in to comment.