added myle-01 patch and switch to .po translation files #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translation
Updated to show age
Spell fixing
Photo can be added to Events
Signed-off-by: Holger Eisold <[email protected]>
Signed-off-by: Holger Eisold <[email protected]>
Signed-off-by: Holger Eisold <[email protected]>
Signed-off-by: Holger Eisold <[email protected]>
Signed-off-by: Holger Eisold <[email protected]>
Signed-off-by: Holger Eisold <[email protected]>
Signed-off-by: Holger Eisold <[email protected]>
Signed-off-by: Holger Eisold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @UksusoFF and @MYLE-01 and others,
I applied the functions which were added by myle from his repo for displaying the age of the person when photo was taken...
I also switched translations to use .po/.mo files and created a .pot file, which extracts all language vars from the code... so translations will be easier... the old .php files are stored und resourse/old_langs so the translators dont have to retranslate from scratch... and its also a good to review the old translations... we later can then delete that folder...
Please feel free to review, apply or delete this PR if you dont agree... others opinions are very welcome, while i still learn to code and use github...
There are also some other things i want to improve... but this is a first start...
cheers
Holger