Sean/allow unknown country processing #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds blocklist functionality, while preserving the allowlist. To make this more useful, we also introduce a default policy: if an IP matches neither allow- or block-list, it will be allowed or not based on the default policy. For CIDR-based lists, higher specificity CIDRs should always take priority to lower-specificity ones. In the event of a tie, the block list should always take priority over the allow list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an IP address is not found in the country database, the previous behaviour was to stop processing. This change allows the processing to continue, to be handled by IP rules or otherwise be handled as the default rule.