(feat) added ashbrook

[starryburst]

new game mode which is like one-night which is a twist on traditional social deduction games like mafia

• roles currently work (i haven't tested every roles reaction to insanity though)
• a few things i want to work on before making it playable (demon/minion reveal, voting system, setup creation, a few more roles?)

[pikulet]

hmm, how is this different from the one night already on the site

[starryburst]

hmm, how is this different from the one night already on the site

it is not one night

[Fsalker]

is this tested? is it playable?

leaving this comment here so I know the commit tree at this point

[pikulet]

hey is there a rulebook for how this is played? still confused

[starryburst]

so i just added the proper checks for closed role setups (the same as mafia does) so that you will be incapable of creating that setup in the first place so that error would not happen

[starryburst]

I'm just putting this here that even though the PR is in draft status it's not currently being worked on as it's waiting to be looked at by someone else (in case people aren't looking at it assuming it's still being worked on and isn't ready)

[DrSharky]

I tested it real quick, just a couple games.
I noticed the "you have used your final vote" message shows up multiple times in the system messages.
Typo in the plaguebearer description: should probably say "see" instead of "seem"
Semantic consistency issue in Starseeker description: should probably say "role" instead of "character"
Grammar typo in Starseeker description: Should probably say "player's" instead of "players".

Also, when creating a setup, should the role count for villager, outcast, follower, and leader be visible? I noticed I can see that even if closed role/unique role option is not selected.

Just a few things I noticed so far. I will test more, making sure I understand the game and that it runs well. Then I'll review the code itself.

[starryburst]

I tested it real quick, just a couple games. I noticed the "you have used your final vote" message shows up multiple times in the system messages. Typo in the plaguebearer description: should probably say "see" instead of "seem" Semantic consistency issue in Starseeker description: should probably say "role" instead of "character" Grammar typo in Starseeker description: Should probably say "player's" instead of "players".

Also, when creating a setup, should the role count for villager, outcast, follower, and leader be visible? I noticed I can see that even if closed role/unique role option is not selected.

Just a few things I noticed so far. I will test more, making sure I understand the game and that it runs well. Then I'll review the code itself.

for final vote can you show me what happened? i'm not sure how to replicate it

for the role count thing the game is a closed role gamemode (there is no closed role toggle, which is why you see the role counts by default)