CURA-12352 Different minimum layer time for layers that contain overhangs #20039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a758ebb.
…fferent-minimum-layer-time-for-layers-that-contain-overhangs
…ang' into CURA-12352_different-minimum-layer-time-for-layers-that-contain-overhangs
rburema
reviewed
Jan 15, 2025
| @@ -8401,15 +8426,13 @@ | |||
| "value": "support_angle", | |||
| "settable_per_mesh": true | |||
| }, | |||
| "wall_overhang_speed_factor": | |||
| "wall_overhang_speed_factors": | |||
There was a problem hiding this comment.
We can't really change settings like this without doing an upgrader.
People will have values like 2.5 for a setting that no longer exists, that should be altered to [3] for this 'new' setting. (In other words: Older files should still work as expected.)
There was a problem hiding this comment.
The usual process (as far as I understood) is to note the required setting update in the dedicated ticket (in this case, CURA-12359) and write the whole upgrade script at once. But as you implemented it, it's also good :)
Nescesary because of the updated overhang wall-speed setting. part of CURA-12352
…layers-that-contain-overhangs
|
I do approve this PR, but I can't because I created it 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CURA-12352
Comes with Ultimaker/CuraEngine#2187