Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AddCoolingProfile.py #20093

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

GregValiant
Copy link
Collaborator

@GregValiant GregValiant commented Jan 1, 2025

Add control for a Build Volume fan.
Add 'Idle speed' for the inactive extruder rather than always going to "0".
General cleanup in the code

Type of change

  • [ X] New features (non-breaking change which adds functionality)

Test Configuration:

  • Operating System:
    Win 10 Pro
    All Cura versions

Checklist:

  • [ X] My code follows the style guidelines of this project as described in UltiMaker Meta and Cura QML best practices
  • [X ] I have read the Contribution guide
  • [ X] I have commented my code, particularly in hard-to-understand areas
  • [ X] I have uploaded any files required to test this change

@github-actions github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Jan 1, 2025
@GregValiant GregValiant added the PR: Post Processing ➕ Like adding beeps, more tunability or different Gcode pause at heights label Jan 1, 2025
@GregValiant GregValiant requested a review from HellAholic January 1, 2025 17:14
Copy link
Contributor

github-actions bot commented Jan 1, 2025

Test Results

23 370 tests  ±0   23 368 ✅ ±0   55s ⏱️ -1s
     1 suites ±0        2 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 248b591. ± Comparison against base commit 382b98e.

♻️ This comment has been updated with latest results.

Add control for a Build Volume fan.

Update AddCoolingProfile.py

Oops.  Left in a debugging line.
@HellAholic
Copy link
Contributor

Code could use a bit more cleaning up imo, some of the if statements for example could be simplified. You could also do the init() and define self.curaApp and use that instead of Application.getInstance().getGlobalContainerStack() or setting the curaApp in different functions or in the if statements.

Made changes per request.
@GregValiant
Copy link
Collaborator Author

Changes made.
I also added the "if ';POSTPROCESSED' in data[0]" exit line so the script can't run twice.

A little history...This was the first script I'd written. I took it on because I needed it for PETG, and because it had been a feature request here since 2017 and no one else had bothered. I'm quite pleased that there has never been a bug report regarding it (knock-on-wood).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Community Contribution 👑 Community Contribution PR's PR: Post Processing ➕ Like adding beeps, more tunability or different Gcode pause at heights
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants