Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-538 Initial Profiles for Replicator+ #20200

Merged
merged 5 commits into from
Feb 19, 2025
Merged

PP-538 Initial Profiles for Replicator+ #20200

merged 5 commits into from
Feb 19, 2025

Conversation

alanbjorklund
Copy link
Contributor

Add definition for Replicator+, along
with three extruders: SE+, SE+ Tough,
and SE+ Experimental.

Add Replicator+ settings for PLA & TPLA.
These are similar to Method settings,
with some first layer adjustments.

PP-538

Add definition for Replicator+, along
with three extruders: SE+, SE+ Tough,
and SE+ Experimental.

Add Replicator+ settings for PLA & TPLA.
These are similar to Method settings,
with some first layer adjustments.

PP-538
Copy link
Contributor

github-actions bot commented Jan 27, 2025

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit b1dda13. ± Comparison against base commit 144123b.

♻️ This comment has been updated with latest results.

@HellAholic
Copy link
Contributor

image

Draft intent for the PLA has multiple errors with speeds set to 0 for:
Top Surface Outer Wall Speed, Outer Wall Speed, Initial Layer Print Speed, Minimum Speed, Initial Layer Speed

If cloud (DF) functionality is also part of the expected outcome, the name mapping should also be added for printer and extruders.

@alanbjorklund
Copy link
Contributor Author

Thanks for the feedback, I'll push a new commit today. Those zero values are very strange, when I tested this locally there were no missing values or errors.

Some speed values were set to zero accientally,
these updates ensure that all speed params have
non zero values.

Also, I noticed some temperatures were not correct.
I added a few changes to correct layer_0, initial,
and final print temperature values.

The default print temp is still not correct, I will
submit another commit for this.

PP-538
@alanbjorklund
Copy link
Contributor Author

@wawanbreton I corrected the zero values you mentioned. However, when testing this I noticed the print temperatures were incorrect. I was able to adjust 3 of the 4 temperatures, but the material_print_temperature value is still incorrect (200C, when according to ultimaker_pla_175 profile it should be 215C).

I thought this may have been due to the MakerBot vs UltiMaker name we assigned to the Replicator+, but I checked it against the Sketch printers which also use both UltiMaker and MakerBot printer names. The Replicator names are consistent with what we previously released for Sketch printers.

@Frederic98 I remember you mentioned the "+" in the extruder name (Smart Extruder+) might cause issues. Could the incorrect temperature be due to the plus sign?

@Frederic98
Copy link
Contributor

Frederic98 commented Feb 10, 2025

Might need to add the machine to a translation dictionary somewhere in the fdm_material reader plugin

https://github.com/Ultimaker/Cura/blob/main/resources/texts/product_to_id.json

@alanbjorklund
Copy link
Contributor Author

@wawanbreton After adding the product to id update, the temperature is still incorrect. @Frederic98 is going to take a look at this tomorrow.

@Frederic98
Copy link
Contributor

Cura seems to struggle with assembling the stack when first adding the printer. When I changed material to Tough PLA, and then back to PLA, it picked up the machine and nozzle settings from the fdm_material file

@wawanbreton
Copy link
Contributor

Cura seems to struggle with assembling the stack when first adding the printer. When I changed material to Tough PLA, and then back to PLA, it picked up the machine and nozzle settings from the fdm_material file

Any suspicious log about it ?

@Frederic98
Copy link
Contributor

Tried to reproduce it ~5 times but it didn't happen again. I did notice that Cura doesn't respect the preferred_variant_name. Maybe this is a related symptom?

Copy link
Member

@rburema rburema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided that the Replicator+ tickets are far enough along to merge (just) before feature freeze; we'll treat remaining issues as separate bugs, so they can be solved (before and) after beta.

@rburema
Copy link
Member

rburema commented Feb 19, 2025

QA is supposed to merge this normally, but Ali is out sick and we want to go to feature freeze soon.

@rburema rburema merged commit 6cdd537 into main Feb 19, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants